matrei opened a new pull request, #16104: URL: https://github.com/apache/grails-core/pull/16104
This pull request focuses on eliminating SLF4J implementation warnings during compilation and testing across multiple modules by consistently adding the `org.slf4j:slf4j-nop` dependency where appropriate. Additionally, it adjusts a logging statement in the SBOM plugin to reduce log verbosity. The most important changes are: **Suppressing SLF4J Warnings (by module):** *General build and plugin modules:* - Added `compileOnly 'org.slf4j:slf4j-nop'` to the compile classpath in various modules (e.g., `grails-core`, `grails-console`, `grails-codecs`, `grails-controllers`, `grails-converters`, `grails-data-graphql`, `grails-data-hibernate5`, `grails-data-hibernate7`, `grails-data-mongodb`, `grails-async`, `grails-cache`, etc.) to prevent warnings about missing SLF4J implementations during compilation. [[1]](diffhunk://#diff-ae11b410043af7834380b5ebe9348e8f2ea9710cfde80268d56ffd3d0a7bd454R94-R95) [[2]](diffhunk://#diff-332a1aed7c8c49f5590c81f5971e59d0867f94434da33a3e6e6b2025f767e478R66-R67) [[3]](diffhunk://#diff-29c90f5b85762a427c4381b560c7cef637a89ec511e89644aca6911056c8016dR47) [[4]](diffhunk://#diff-9b0330f85c526716ae9da717f7d7f478f984f323da1da16409fa7862652e59caR60) [[5]](diffhunk://#diff-6b0570777539c57b3055a9c047d42e37e4c722f50c639082dfbfb54a71b58bb8R57) [[6]](diffhunk://#diff-2ed49fbbbe5bcf0178efc900ff0a9580a5d7dbf57b7320d453d37a92c0ce177fR82-R92) [[7]](diffhunk://#diff-920faa99 050907540ecf8861f8e10c62998b78c849c37c8d03d3606de17fe97bR81) [[8]](diffhunk://#diff-18077521a4669d34c7ed6d6fe432461fabb6c8d498a7841427123e946724e911R86) [[9]](diffhunk://#diff-9a3e8115587462330492f188b8f55355f4133b8932765796731f4aee2524a34aR103-L107) [[10]](diffhunk://#diff-81c8d9d6e7b64c6309e2ebed3492264f0d191388d239ed36e48a3ab7d5e88724R126) [[11]](diffhunk://#diff-b91e009cadb16616500af3e2a31d464a9a9e0b286504ecef753bc3d2a02f64a8R55-L61) [[12]](diffhunk://#diff-e811591a138a1268ee9ff1a78c130053a93c4f2a5e8dad7470a95a9b2a97378cR56-R65) [[13]](diffhunk://#diff-d8299c0b3919a5b92f65bdcfceb4d79adce538a1d2c6420b32f886ed77e9f400R89) *Test and CLI configurations:* - Added `testCompileOnly` and/or `testImplementation 'org.slf4j:slf4j-nop'` to test configurations in several modules to suppress SLF4J warnings during test compilation and execution. [[1]](diffhunk://#diff-df03346c55a1946a395e10975ca95e799921f33eec738cb5a02c5539cf10d205R77-R79) [[2]](diffhunk://#diff-17c24c310017bcdadd8216a9f7f4e08860c058c18aa9af61c9f13cd3d4886c82R120-R121) [[3]](diffhunk://#diff-18077521a4669d34c7ed6d6fe432461fabb6c8d498a7841427123e946724e911R97-R98) [[4]](diffhunk://#diff-920faa99050907540ecf8861f8e10c62998b78c849c37c8d03d3606de17fe97bR92-R93) [[5]](diffhunk://#diff-9a3e8115587462330492f188b8f55355f4133b8932765796731f4aee2524a34aR103-L107) [[6]](diffhunk://#diff-81c8d9d6e7b64c6309e2ebed3492264f0d191388d239ed36e48a3ab7d5e88724R143-L147) [[7]](diffhunk://#diff-70ff2d2fa6be5d7475fae0f9b7bc07114411b808346dd53c0f6450660b6ae99dR66-R67) [[8]](diffhunk://#diff-2ed49fbbbe5bcf0178efc900ff0a9580a5d7dbf57b7320d453d37a92c0ce177fR82-R92) [[9]](diffhunk://#diff-b91e009cadb166 16500af3e2a31d464a9a9e0b286504ecef753bc3d2a02f64a8R55-L61) [[10]](diffhunk://#diff-e811591a138a1268ee9ff1a78c130053a93c4f2a5e8dad7470a95a9b2a97378cR56-R65) *AST and CLI-specific configurations:* - Added `astCompileOnly` and `cliCompileOnly 'org.slf4j:slf4j-nop'` in appropriate modules to prevent warnings in annotation processing and CLI builds. [[1]](diffhunk://#diff-e811591a138a1268ee9ff1a78c130053a93c4f2a5e8dad7470a95a9b2a97378cR43-R45) [[2]](diffhunk://#diff-2565acf8b7d676c046c5823c98f182591ee76f82fa03d04fd2376ec5b0e24614R88) [[3]](diffhunk://#diff-0db02c0a03aa91d23c1a341b6ef0391e6f76666b119a2f5e6dee2eab43ff067eR85) [[4]](diffhunk://#diff-18077521a4669d34c7ed6d6fe432461fabb6c8d498a7841427123e946724e911R59-R60) [[5]](diffhunk://#diff-920faa99050907540ecf8861f8e10c62998b78c849c37c8d03d3606de17fe97bR57) **Logging adjustment:** *SBOM Plugin:* - Changed the log level from `lifecycle` to `info` for the message about forcing a license in `SbomPlugin.groovy`, reducing log verbosity during builds. These changes collectively improve the developer experience by ensuring cleaner build and test logs and more consistent dependency management. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
