bito-code-review[bot] commented on PR #16143: URL: https://github.com/apache/grails-core/pull/16143#issuecomment-5272629733
<!-- Bito Reply --> The suggestion to add a JoinType assertion to the test is appropriate. Verifying that `DynamicFinder.applyDetachedCriteria` correctly calls `Query#join(property, JoinType)` ensures the bugfix is functional and prevents future regressions in the query generation logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
