jdaugherty commented on code in PR #16094:
URL: https://github.com/apache/grails-core/pull/16094#discussion_r3776025542
##########
dependencies.gradle:
##########
@@ -126,8 +126,8 @@ ext {
'sitemesh.version' : '2.6.0',
'scribejava.version' : '8.3.3',
'spock.version' : '2.4-groovy-5.0',
- 'starter-sitemesh.version' : '3.3.0-M3',
- 'spring-webmvc-sitemesh.version': '3.3.0-M3',
+ 'starter-sitemesh.version' : '3.3.0-SNAPSHOT',
Review Comment:
Blocker for merge, as you note in the description. Beyond the pin itself,
two things need resolving before this can land:
1. An ASF release cannot depend on a SNAPSHOT. This has to be a released
`spring-webmvc-sitemesh`/`starter-sitemesh` before merge, not after.
2. `3.3.0-SNAPSHOT` is not resolvable from the repositories this build
declares, so CI on this branch is not actually building what the PR claims.
Anything green here should be treated as untested until the pin lands.
Given the size of the rest of the change, I'd rather see the
SiteMesh-dependent part (`GrailsSiteMeshViewResolver` + this bump) split out
and merged after the upstream release, so the AOT work isn't held hostage to it.
##########
.sdkmanrc:
##########
@@ -5,7 +5,7 @@
# $JAVA_VERSION_MICRONAUT in release.yml; for local verification, install that
JDK 25
# alongside this one (sdk install java <version>-librca) and follow the
dual-JDK
# instructions in RELEASE.md "Manual Verification: Reproducible Jar Files".
-java=21.0.7-librca
+java=21.0.12-librca
Review Comment:
The JDK bump (here, `release.yml`, `release-publish-docs.yml`,
`etc/bin/Dockerfile`) has nothing to do with AOT and changes the JDK the
reproducible-build guarantee is pinned to. Please pull it into its own PR so it
can be verified against `verify-reproducible.sh` independently — a
release-toolchain change should not ride along in a feature branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
