jdaugherty commented on code in PR #16094:
URL: https://github.com/apache/grails-core/pull/16094#discussion_r3776025825
##########
grails-core/src/main/groovy/grails/boot/GrailsBanner.groovy:
##########
@@ -363,10 +666,13 @@ class GrailsBanner implements Banner {
/**
* Enumeration of optional version options.
+ *
+ * <p>The container being run is shown by default under {@code container},
which is the one an
+ * application is on. These name a particular container instead, for an
application that wants
+ * to be told about one whether or not it is the one serving.</p>
*/
@CompileStatic
enum OptionalVersionOption {
Review Comment:
`SPRING_SECURITY` is removed from `OptionalVersionOption` and moved into
`DefaultVersionOption`. `OptionalVersionOption` is a public enum on a public
class — removing a constant is a source- and binary-breaking change for
anything referencing it, and it isn't listed in `upgrading80x.adoc`.
More generally: the whole banner rework in this file (ANSI colouring, the
NATIVE/AOT CACHE mark, `CONTAINER`, the default-set changes) is a user-visible
feature that is independent of making an application AOT-processable. Only
`resolveMark()` needs the AOT work at all. Please split the banner into its own
PR — it's the part most likely to attract bikeshedding, and holding the AOT fix
behind it helps nobody.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
