jdaugherty commented on code in PR #16452:
URL: https://github.com/apache/grails-core/pull/16452#discussion_r4153697876


##########
grails-mail/src/main/groovy/grails/plugins/mail/MailMessageBuilder.groovy:
##########
@@ -234,7 +238,7 @@ class MailMessageBuilder {
     void from(CharSequence from) {
         def value = from.toString()
         Assert.hasText(value, 'from cannot be null or 0 length')
-        getMessage().from = value
+        getMessage().from = overrideFromAddress ?: value

Review Comment:
   This deserves an upgrade note at a minimum due to the change in behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to