ruthst00 commented on PR #16452:
URL: https://github.com/apache/grails-core/pull/16452#issuecomment-5949163507
@matrei, thanks for the feedback. Changes made during second round:
`upgrading80x.adoc`, `SKILL.md`, and `mailConfiguration.adoc` have been
updated to accurately reflect the implementation in `MailMessageBuilder.groovy`
and `MailConfigurationProperties`. The key changes from the original text:
1. Removed the misleading "No action is required" paragraph — the original
claimed `overrideAddress` works "exactly as before," which was confusing given
the new fallback logic being described right above it.
2. Clarified the fallback behavior — each specific property
(`overrideToAddress`, `overrideFromAddress`) falls back to `overrideAddress`
when not set.
3. Expanded the bullet descriptions to match the actual implementation:
- `overrideToAddress` covers to, cc, and bcc (not just "recipient
addresses"), and also acts as the default `to` when none is set in the closure.
- `overrideFromAddress` overrides the sender including explicit `from`
calls, and also acts as the **default `from`** when none is set.
4. Updated the comment in the `overrideToAddress` YAML example to say
"redirect all recipients (to, cc, bcc) only" for clarity.
5. Mentioned that `overrideAddress` now also replaces a `from` set
explicitly in sendMail. An application that wants to keep its real sender
should use `overrideToAddress` in place of `overrideAddress`.
Also:
- Dropped "backward-compatibility" from test "Test that overrideAddress
overrides the explicit from address"
- `mailTesting.adoc` reverted back to say "The disadvantage is that it
requires a real SMTP server and makes it difficult to test address
determination logic.". Also updated language to reflect logic changes.
- Removed redundant test "Test that overrideAddress overrides both to and
from"
- Updated PR description to reflect all new changes and tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
