ruthst00 commented on code in PR #16452:
URL: https://github.com/apache/grails-core/pull/16452#discussion_r4157594306
##########
grails-mail/src/main/groovy/grails/plugins/mail/MailMessageBuilder.groovy:
##########
@@ -234,7 +238,7 @@ class MailMessageBuilder {
void from(CharSequence from) {
def value = from.toString()
Assert.hasText(value, 'from cannot be null or 0 length')
- getMessage().from = value
+ getMessage().from = overrideFromAddress ?: value
Review Comment:
Four documentation files now reflect the new `overrideToAddress` and
`overrideFromAddress` mail plugin properties:
1. **`grails-doc/src/en/guide/mail/mailConfiguration.adoc`** — "Overriding
Addresses" section documents all three properties with YAML examples and
precedence rules.
2. **`grails-doc/src/en/guide/mail/mailTesting.adoc`** — "Using an Override
Address" section was expanded into two sub-sections: "Overriding All Addresses"
(the existing `overrideAddress`) and "Overriding Recipients and Sender
Independently" (the new `overrideToAddress` / `overrideFromAddress`), each with
a `application-test.yml` example.
3. **`grails-doc/src/en/guide/upgrading/upgrading80x.adoc`** — New section
80 covers the change for applications upgrading from Grails 7.
4. **`.agents/skills/grails-8-upgrade/SKILL.md`** — Concise checklist entry
added for AI agents performing Grails 8 upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
