codeconsole commented on PR #16472: URL: https://github.com/apache/grails-core/pull/16472#issuecomment-5956839147
@matrei Thanks, all four hold. 1. **Windows separators:** fixed. The path is now joined from its names with `/`, so `IOUtils.findRootResourcesURL` and `findResourceRelativeToClass` keep matching. Both features now expect `build/classes/groovy/main` and `build-parent/build-8070/classes/groovy/main` on every platform, and a unit spec covers the joining. 2. **Plugin subprojects:** the build that ran into this has about twenty plugin subprojects, and `-PbuildDir` moves every project's build directory the same way relative to itself, so the path is right for them too. A layout where only the application moves, or where build directories are relative to the root, isn't handled. The provider's Javadoc now says the path is assumed to be laid out the same way in every project. 3. **Resources:** agreed, that belongs in a separate PR. 4. **7.0.x:** not a deliberate choice; I only ran into it on 8. Happy to open a backport to 7.0.x once this is merged, or to retarget if you'd rather it merge up. **Nit:** done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
