codeconsole commented on PR #16472: URL: https://github.com/apache/grails-core/pull/16472#issuecomment-5958182184
@jdaugherty Thanks for the approval, and for checking what the forked JVM gets with the configuration cache. Both inline points are fixed; I've replied in the threads. I've also folded the resources follow-up into this PR, since it's the same gap: - The plugin now passes `grails.project.resource.dir` as well. The provider became `GrailsProjectOutputDirProvider` and is used for both properties. - `BuildSettings.BUILD_RESOURCES_PATH` reads that property, so the i18n plugin copies a changed message bundle into the build the application runs from. - `IOUtils` maps a class root to its resources root by the build's classes and resources paths instead of replacing `/build/classes/groovy/`, which never matched a moved build directory. I left `TARGET_DIR` alone, as you noted it reads `project.target.dir`. It stays `<base>/build`, which is where the run-app PID file has to be for the CLI, and with `grails.project.resource.dir` passed, `RESOURCES_DIR` no longer depends on it. Since this now touches `BuildSettings` and `IOUtils`, @matrei @jdaugherty it needs another look. The description is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
