codeconsole commented on PR #16472: URL: https://github.com/apache/grails-core/pull/16472#issuecomment-5956839527
@sbglasius Thanks. 1 and 3 hold and are fixed; 2 holds in part. 1. **Different roots:** a classes directory with no path relative to the project now passes no property, so the application keeps the `build/classes/groovy/main` fallback instead of `bootRun` failing. 2. **`../` paths:** `GrailsApp.recompile`, `MainClassFinder` and the i18n plugin join the value with `new File(dir, path)`, which resolves `..`, so they work. The `IOUtils` lookups compare it with a class location and don't match, but they didn't match a moved build directory before this PR either, so they fall back as before. The Javadoc now says so. 3. **Tests:** added a feature for a build directory outside the project, and a unit spec for the path that includes the different-roots fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
