borinquenkid commented on PR #16719: URL: https://github.com/apache/grails-core/pull/16719#issuecomment-6349044560
Update on point 2: rather than ask you to start `HqlText` here, I am taking the shared scanner on as part of the fix for #16717, on branch `feat/sql-text-8.0.x` (8.0.x). It adds one `SqlText` class that owns the lexical rules once (literals with doubled quotes, quoted and bracket identifiers, dollar quotes, both comment kinds, parenthesis depth) with `indexOfTopLevel`, `splitTopLevel` and `unwrapOuterParentheses`, migrates the `HqlQueryContext` and `SqlProjection` scanners onto it, and has one spec table of awkward inputs. Once it is pushed, this fix becomes a call to `unwrapOuterParentheses` plus the union-branch handling, and your cases become rows in `SqlTextSpec`. I will link the PR here; please base on it then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
