skrawcz commented on code in PR #1489: URL: https://github.com/apache/hamilton/pull/1489#discussion_r2969958504
########## dev_tools/language_server/tests/conftest.py: ########## @@ -1,21 +1,20 @@ -############################################################################ -# Original work Copyright 2017 Palantir Technologies, Inc. # -# Original work licensed under the MIT License. # -# See ThirdPartyNotices.txt in the project root for license information. # -# All modifications Copyright (c) Open Law Library. All rights reserved. # -# # -# Licensed under the Apache License, Version 2.0 (the "License") # -# you may not use this file except in compliance with the License. # -# You may obtain a copy of the License at # -# # -# http: // www.apache.org/licenses/LICENSE-2.0 # -# # -# Unless required by applicable law or agreed to in writing, software # -# distributed under the License is distributed on an "AS IS" BASIS, # -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # -# See the License for the specific language governing permissions and # -# limitations under the License. # Review Comment: I did some digging on this. Comparing our `conftest.py` against the [upstream pygls conftest.py](https://github.com/openlawlibrary/pygls/blob/main/tests/conftest.py): - The pygls version is **319 lines** with 8 fixtures, a `LanguageClient` class, pytest CLI hooks, and e2e test infrastructure. - Our version is **37 lines** with a single `client_server` fixture that imports `HamiltonLanguageServer` and `NativeClientServer` — entirely Hamilton-specific code. - The only shared element is the standard pytest pattern of "create fixture → start → yield → stop", which isn't copyrightable expression. **The Palantir/Open Law Library header can be removed from `conftest.py`** — there's no substantive code from the original remaining. The header was copy-pasted when the file was created, but the actual code was written fresh. **`ls_setup.py` is a different story** — the `NativeClientServer` class is a near line-for-line derivative of pygls's `ClientServer` class, so the Open Law Library header must stay there. The attribution in `dev_tools/language_server/LICENSE` that this PR adds is the right approach for that file. @Dev-iL — go ahead and remove the Palantir header from `conftest.py` and add the standard Apache header instead. Keep `ls_setup.py` as-is with the Open Law Library header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
