pjfanning commented on code in PR #1489: URL: https://github.com/apache/hamilton/pull/1489#discussion_r2971295227
########## dev_tools/language_server/tests/ls_setup.py: ########## @@ -1,19 +1,20 @@ -############################################################################ -# Copyright(c) Open Law Library. All rights reserved. # -# See ThirdPartyNotices.txt in the project root for additional notices. # Review Comment: You don't move license info to the NOTICE. If you use 3rd party code that has a NOTICE then its NOTICE contents must be included in your NOTICE. This whole issue is caused by the possibility that there is 3rd party code. @Dev-iL and I have looked at that file and if there ever was 3rd party code, it now appears to have been removed from the file. If we can make a call on if there is 3rd party code in that file - that is the most important decision here. Everything else depends on that starting block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
