Dev-iL commented on code in PR #1489: URL: https://github.com/apache/hamilton/pull/1489#discussion_r2971401900
########## dev_tools/language_server/tests/ls_setup.py: ########## @@ -1,19 +1,20 @@ -############################################################################ -# Copyright(c) Open Law Library. All rights reserved. # -# See ThirdPartyNotices.txt in the project root for additional notices. # Review Comment: @pjfanning Indeed, this PR has accumulated more discussion than I'd have liked. That said, I think we're actually at the finish line now. The only "license mess" was the two LSP test files (`conftest.py` and `ls_setup.py`), and that's been resolved thanks to @skrawcz's analysis. Splitting this into separate PRs at this point would mean re-doing the pre-commit hook configuration and exclusion logic across multiple branches, which is likely more churn than just landing it as-is. Let's use this as a learning experience for the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
