Duansg commented on PR #3673: URL: https://github.com/apache/hertzbeat/pull/3673#issuecomment-3224900335
Hi, @bigcyy I pulled your PR and gave it a quick spin. Overall, aside from some UI interactions that need polishing ,it's pretty well-rounded. I'd be happy to be the first user after this PR merges, hahaha. :+1: Maybe we can even build this feature together :) Here are some of my questions and suggestions: 1. Without Greptime enabled, can the `Log Manage` list page display a user-friendly prompt instead of an error message? 2. In the Threshold configuration, the `Alarm Content` now displays in a single column. Was this intentional? 3. In the `Periodic Threshold` configuration, do both metrics and logs now support PROMQL and SQL? Because I noticed that when using SQL queries for metrics, they failed to display properly. 4. Could we consider initializing the `Log Stream` in a `pause` state? When `resume` is triggered, it would then initialize the connection state. Additionally, should we adjust the automatic refresh of input parameters to: take effect only when manually paused/enabled? Currently, when I input filtering parameters, if I haven't finished entering them before resetting the SSE, I lose the reference logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
