bigcyy commented on code in PR #3673:
URL: https://github.com/apache/hertzbeat/pull/3673#discussion_r2302892613
##########
hertzbeat-common/src/main/java/org/apache/hertzbeat/common/entity/alerter/AlertDefine.java:
##########
@@ -100,6 +100,11 @@ public class AlertDefine {
@Size(max = 100)
private String datasource;
+ @Schema(title = "Query Expression", example = "SELECT * FROM metrics WHERE
value > 90")
+ @Size(max = 2048)
+ @Column(length = 2048)
+ private String queryExpr;
+
Review Comment:
Hi Tom,
I understand the alerting capabilities of Alibaba Cloud's SLS, particularly
why two expressions are needed for advanced scenarios.
- Setting multi-level alerts: Binding different threshold expressions to
various severity levels (e.g., critical, warning) based on the same query
result.
- Conducting visual analysis: Creating complex visualizations from the query
results before alerting.
- Creating composite alerts: Combining results from multiple, separate
queries into a single, consolidated alert.
However, after carefully reviewing our specific requirements, I've confirmed
that our current alerting logic doesn't involve these complexities. Our needs
can be fully and efficiently met with just a single expression.
To keep our configuration streamlined and better aligned with our use case,
I will proceed with modifying our setup to use a single-expression alert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
