bigcyy commented on PR #3673: URL: https://github.com/apache/hertzbeat/pull/3673#issuecomment-3226833914
> Hi, @bigcyy I pulled your PR and gave it a quick spin. Overall, aside from some UI interactions that need polishing ,it's pretty well-rounded. I'd be happy to be the first user after this PR merges, hahaha. 👍 > > Maybe we can even build this feature together :) > > Here are some of my questions and suggestions: > > 1. Without Greptime enabled, can the `Log Manage` list page display a user-friendly prompt instead of an error message? > 2. In the Threshold configuration, the `Alarm Content` now displays in a single column. Was this intentional? > 3. In the `Periodic Threshold` configuration, do both metrics and logs now support PROMQL and SQL? Because I noticed that when using SQL queries for metrics, they failed to display properly. > 4. Could we consider initializing the `Log Stream` in a `pause` state? When `resume` is triggered, it would then initialize the connection state. Additionally, should we adjust the automatic refresh of input parameters to: take effect only when manually paused/enabled? Currently, when I input filtering parameters, if I haven't finished entering them before resetting the SSE, I lose the reference logs. Hi! Thanks so much for the detailed feedback and for taking the time to test out my PR. I'm glad to hear you found it well-rounded. It would be an honor to have you as the first user! I appreciate the offer to collaborate, but as this is part of my OSPP activity, I need to complete this PR by myself. After it's merged into the main branch, I would be very happy to collaborate on future improvements based on your interest. Here are my thoughts on your questions and suggestions: - Log Management Page Prompt: This is an excellent suggestion. I agree that a user-friendly prompt would be much better than an error message, and I'll make sure to address this in a future update. - Alarm Content Display: The **Alarm Content** is designed to display as a grouped alert by default, which is why it shows in a single column. - Periodic Threshold Queries: Currently, logs don't support PromQL. I'll make sure the front end is updated to reflect this limitation. Metrics should support SQL queries, so I'll investigate why they failed to display properly. Thanks for pointing that out! - Log Stream State: You're suggesting that the Log Stream should be paused by default when you first enter the page. Is that correct? I think that's a great idea. As for the filtering parameters, what if we changed it so that the filtering only takes effect when you click a button? That way, you'd have time to finish typing before the SSE connection resets. Thanks again for all your help and for taking the time to review my PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
