AMashenkov commented on a change in pull request #328:
URL: https://github.com/apache/ignite-3/pull/328#discussion_r706082359
##########
File path:
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTupleGetAndDeleteRequest.java
##########
@@ -46,6 +47,6 @@
var table = readTable(in, tables);
var tuple = readTuple(in, table, true);
- return table.getAndDeleteAsync(tuple).thenAccept(resTuple ->
writeTuple(out, resTuple));
+ return table.getAndDeleteAsync(tuple).thenAccept(resTuple ->
writeTuple(out, resTuple, TuplePart.VAL));
Review comment:
Do you plan to reuse this (and similar) methods in Table binary view?
I think user expects TableView.get(t) will return full row (key+value
parts), but KvView will return "value" part only, thought.
Shouldn't TuplePart be passed from outside?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
