ptupitsyn commented on a change in pull request #328:
URL: https://github.com/apache/ignite-3/pull/328#discussion_r706779249
##########
File path:
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTupleGetAndDeleteRequest.java
##########
@@ -46,6 +47,6 @@
var table = readTable(in, tables);
var tuple = readTuple(in, table, true);
- return table.getAndDeleteAsync(tuple).thenAccept(resTuple ->
writeTuple(out, resTuple));
+ return table.getAndDeleteAsync(tuple).thenAccept(resTuple ->
writeTuple(out, resTuple, TuplePart.VAL));
Review comment:
> Do you plan to reuse this (and similar) methods in Table binary view?
This is a server-side handler. `Table` and `KvView` APIs only differ in the
way they return data to the user, but the data is the same. There is nothing
specific to `Table` or `KvView` on the protocol level - all operations are
shared.
For `Get*` operations we only return the value part from the server, because
the client already knows the key. For the `Table` view, we combine returned
value columns with known key columns to create the full row and return it to
the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
