anton-vinogradov commented on a change in pull request #9345:
URL: https://github.com/apache/ignite/pull/9345#discussion_r824722058
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupContext.java
##########
@@ -1204,12 +1207,28 @@ public void onReconnected() {
}
/**
- * WAL enabled flag.
+ * Value returned by this method can be changed runtime by the user or
during rebalance.
+ *
+ * @return WAL enabled flag.
+ * @see IgniteCluster#disableWal(String)
+ * @see IgniteCluster#enableWal(String)
*/
public boolean walEnabled() {
Review comment:
That's in scope, see comment above.
To simplify everything (you added `grp.persistenceEnabled()` everywhere,
while it should be encapsulated) after the change we must have 3 methods:
`localWalEnabled`, `walEnabled`, `walOrCdcEnabled` where last two uses the
first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
