anton-vinogradov commented on a change in pull request #9345:
URL: https://github.com/apache/ignite/pull/9345#discussion_r824845857
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupContext.java
##########
@@ -1204,12 +1207,28 @@ public void onReconnected() {
}
/**
- * WAL enabled flag.
+ * Value returned by this method can be changed runtime by the user or
during rebalance.
+ *
+ * @return WAL enabled flag.
+ * @see IgniteCluster#disableWal(String)
+ * @see IgniteCluster#enableWal(String)
*/
public boolean walEnabled() {
Review comment:
every `walEnabled ` usage (except CheckpointWorkflow) now covered by
existing or added `&& grp.persistenceEnabled()`.
It's good to encapsulate this to `walEnabled ` with renaming of current
`walEnabled` to `localWalEnabled`
Just to minimize length of if's conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]