anton-vinogradov commented on a change in pull request #9345:
URL: https://github.com/apache/ignite/pull/9345#discussion_r826040104
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java
##########
@@ -3116,6 +3118,7 @@ private GridCacheSharedContext createSharedContext(
verMgr,
mvccMgr,
pageStoreMgr,
+ CU.isPersistenceEnabled(ctx.config()) ? walMgr : null,
Review comment:
Could we encapsulate this inside `GridCacheSharedContext`?
No need to pass `cdcWalMgr` param, we able to resolve everything from
`kernalCtx` and `walMgr` inside the constructor atomically.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java
##########
@@ -4410,7 +4410,7 @@ protected WALPointer logMvccUpdate(IgniteInternalTx tx,
CacheObject val, long ex
else
op = this.val == null ? GridCacheOperation.CREATE : UPDATE;
- return cctx.shared().wal().log(new MvccDataRecord(new
MvccDataEntry(
+ return cctx.shared().wal(cctx.group().cdcEnabled()).log(new
MvccDataRecord(new MvccDataEntry(
Review comment:
Looks like we able to change access point from `cctx.shared().wal()` to
`cctx.group().wal()` and resolve `cctx.group().cdcEnabled()` inside the new
method.
This will minimize the changes just to `shared()` -> `group()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
