rpuch commented on code in PR #1461:
URL: https://github.com/apache/ignite-3/pull/1461#discussion_r1055474328
##########
modules/network/src/main/java/org/apache/ignite/network/DefaultMessagingService.java:
##########
@@ -275,7 +280,13 @@ private void sendToSelf(NetworkMessage msg, @Nullable Long
correlationId) {
*/
private void onMessage(InNetworkObject obj) {
if (isInNetworkThread()) {
- inboundExecutor.execute(() -> onMessage(obj));
+ inboundExecutor.execute(() -> {
+ try {
+ onMessage(obj);
+ } catch (RuntimeException e) {
+ LOG.warn("onMessage() failed while processing " +
obj.message() + " from " + obj.consistentId(), e);
Review Comment:
Switched it to `{}` style, added a guard to only do this work when the
corresponding logging level is enabled. Switched the level to INFO (because we
need to see these messages, at least during the active development phase, this
really helps in debugging faulty runs on TC).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
