rpuch commented on code in PR #1461:
URL: https://github.com/apache/ignite-3/pull/1461#discussion_r1057614303
##########
modules/network/src/main/java/org/apache/ignite/network/DefaultMessagingService.java:
##########
@@ -402,7 +419,8 @@ public void stop() {
/**
* Installs a predicate, it will be consulted with for each message being
sent; when it returns {@code true}, the
- * message will be silently dropped (it will not be sent, the
corresponding future will never complete).
+ * message will be dropped (it will not be sent; the corresponding future
will time out soon for {@code invoke()} methods
Review Comment:
'invoke' is different from 'send' in that it has `timeout` parameter, so, if
the recipient never responds, a timeout happens sooner or later. For 'send',
this is not the case: if the recipient never responds, the future just hangs
forever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
