rpuch commented on code in PR #1461:
URL: https://github.com/apache/ignite-3/pull/1461#discussion_r1057606190
##########
modules/cluster-management/src/integrationTest/java/org/apache/ignite/internal/cluster/management/MockNode.java:
##########
@@ -77,7 +82,13 @@ private void init(int port) throws IOException {
this.clusterService = ClusterServiceTestUtils.clusterService(testInfo,
port, nodeFinder);
- Loza raftManager = new Loza(clusterService, null, workDir, new
HybridClockImpl());
+ RaftConfiguration raftConfiguration = mock(RaftConfiguration.class);
Review Comment:
Currently, only 3 tests use `MockNode`. Neither of them needs to pass
configuration, so only the constructor that does not accept the configuration
and just mocks it is used. So if I add the second constructor (that accepts
`RaftConfiguration`), this constructor will simply not be used at all. I think
we should not add what we don't need yet. If we need it in the future, we'll
add that constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
