sanpwc commented on code in PR #2172:
URL: https://github.com/apache/ignite-3/pull/2172#discussion_r1229168979
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1027,44 +1030,52 @@ private void initDataNodesFromVaultManager() {
try {
long appliedRevision = metaStorageManager.appliedRevision();
- VaultEntry topologyEntry =
vaultMgr.get(zonesLogicalTopologyKey()).join();
-
- if (topologyEntry != null && topologyEntry.value() != null) {
- assert appliedRevision > 0 : "The meta storage last applied
revision is 0 but the logical topology is not null.";
-
- logicalTopology = fromBytes(topologyEntry.value());
-
- logicalTopology.forEach(n -> nodesAttributes.put(n.nodeId(),
n.nodeAttributes()));
+ restoreGlobalStateFromVault();
Review Comment:
I've tried to understand what
`initLogicalTopologyAndVersionInMetaStorageOnStart` should do though it's
javadoc and failed with this.
```
/**
* Initialises {@link DistributionZonesUtil#zonesLogicalTopologyKey()}
and
* {@link DistributionZonesUtil#zonesLogicalTopologyVersionKey()} from
meta storage on the start of {@link DistributionZoneManager}.
*/
```
What do you mean by `Initialises {@link
DistributionZonesUtil#zonesLogicalTopologyKey()}` for example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
