sanpwc commented on code in PR #2172:
URL: https://github.com/apache/ignite-3/pull/2172#discussion_r1229398452
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1119,9 +1130,8 @@ public CompletableFuture<Void> onUpdate(WatchEvent evt) {
.map(NodeWithAttributes::node)
.collect(toSet());
- newLogicalTopology.forEach(n ->
nodesAttributes.put(n.nodeId(), n.nodeAttributes()));
+
updateLogicalTopologyNodeAttributesAndSaveToVault(newLogicalTopology);
Review Comment:
So, as a result we may finish with an inconsistent vault state, if we will
fail right after `updateLogicalTopologyNodeAttributesAndSaveToVault` when
applied revision will be x but logicalTopology and node attributes will match x
+ 1. It's not a problem right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
