lowka commented on code in PR #2199:
URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236759236
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java:
##########
@@ -63,6 +72,113 @@ public <RowT> Publisher<RowT> scan(ExecutionContext<RowT>
ctx, PartitionWithTerm
pub = internalTable.scan(partWithTerm.partId(), txAttributes.id(),
recipient, null, null, null, 0, null);
}
- return StorageScanNode.convertPublisher(pub, (item) ->
rowConverter.toRow(ctx, item, rowFactory, requiredColumns));
+ return new TransformingPublisher<>(pub, item ->
rowConverter.toRow(ctx, item, rowFactory, requiredColumns));
}
+
+ /** {@inheritDoc} */
+ @Override
+ public <RowT> Publisher<RowT> indexRangeScan(ExecutionContext<RowT> ctx,
PartitionWithTerm partWithTerm, RowFactory<RowT> rowFactory,
+ int indexId, String indexName, List<String> columns, @Nullable
RangeCondition<RowT> cond, @Nullable BitSet requiredColumns) {
Review Comment:
@AMashenkov I added indexName to simplify testing because there is no way
to connect `indexId` and a call index scan/lookup methods (yes, there are tests
in the main branch that intercept index scans and we are going to need this
anyways)).
An alternative would require moving index scans/lookup to a separate class +
making all the necessary changes to make it accessible from
`LogicalRelImplementor::visit(IgniteIndexScan rel)`. I think this approach
would create a lot of unnecessary complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
