lowka commented on code in PR #2199:
URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1238450830
##########
modules/table/src/main/java/org/apache/ignite/internal/utils/PrimaryReplica.java:
##########
@@ -57,4 +59,26 @@ public ClusterNode node() {
public long term() {
return term;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ PrimaryReplica that = (PrimaryReplica) o;
+ return term == that.term && Objects.equals(node, that.node);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(node, term);
+ }
+
+ @Override
Review Comment:
Fixed.
##########
modules/table/src/main/java/org/apache/ignite/internal/utils/PrimaryReplica.java:
##########
@@ -57,4 +59,26 @@ public ClusterNode node() {
public long term() {
return term;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ PrimaryReplica that = (PrimaryReplica) o;
+ return term == that.term && Objects.equals(node, that.node);
+ }
+
+ @Override
Review Comment:
Fixed.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/NoOpTransaction.java:
##########
@@ -43,14 +43,32 @@ public final class NoOpTransaction implements
InternalTransaction {
private final TablePartitionId groupId = new TablePartitionId(1, 0);
+ private final boolean readOnly;
+
/**
- * Constructs the object.
+ * Constructs a read only transaction.
*
* @param name Name of the node.
*/
public NoOpTransaction(String name) {
+ this(name, true);
+ }
+
+ /**
+ * Constructs a transaction.
+ *
+ * @param name Name of the node.
+ * @param readOnly Read-only or not.
+ */
+ public NoOpTransaction(String name, boolean readOnly) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
