lowka commented on code in PR #2199:
URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1236859774
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTableRegistrySelfTest.java:
##########
@@ -79,9 +88,10 @@ public void testGetTable() {
CompletableFuture<ExecutableTable> f = tester.getTable(tableId);
ExecutableTable executableTable = f.join();
- assertNotNull(executableTable.scanableTable());
+ assertNotNull(executableTable.scannableTable());
assertNotNull(executableTable.updatableTable());
- assertNotNull(executableTable.rowConverter());
+
+ verify(callback).onTableLoaded(eq(executableTable), eq(TABLE_NAME),
eq(descriptor));
Review Comment:
I think `Mockito.spy` should be used for partial mocks (see Mockito docs) in
some pathological cases of legacy code when one can not even provide an
adapter.
So I see no reason to use it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
