lowka commented on code in PR #2199:
URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239314550
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java:
##########
@@ -63,6 +72,113 @@ public <RowT> Publisher<RowT> scan(ExecutionContext<RowT>
ctx, PartitionWithTerm
pub = internalTable.scan(partWithTerm.partId(), txAttributes.id(),
recipient, null, null, null, 0, null);
}
- return StorageScanNode.convertPublisher(pub, (item) ->
rowConverter.toRow(ctx, item, rowFactory, requiredColumns));
+ return new TransformingPublisher<>(pub, item ->
rowConverter.toRow(ctx, item, rowFactory, requiredColumns));
}
+
+ /** {@inheritDoc} */
+ @Override
+ public <RowT> Publisher<RowT> indexRangeScan(ExecutionContext<RowT> ctx,
PartitionWithTerm partWithTerm, RowFactory<RowT> rowFactory,
+ int indexId, String indexName, List<String> columns, @Nullable
RangeCondition<RowT> cond, @Nullable BitSet requiredColumns) {
Review Comment:
@AMashenkov Replaced ItSecondaryIndexTest tests that with unit tests for
`ExpressionFactoryImplTest` that validate nulls / null bounds.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTableRegistrySelfTest.java:
##########
@@ -79,9 +88,10 @@ public void testGetTable() {
CompletableFuture<ExecutableTable> f = tester.getTable(tableId);
ExecutableTable executableTable = f.join();
- assertNotNull(executableTable.scanableTable());
+ assertNotNull(executableTable.scannableTable());
assertNotNull(executableTable.updatableTable());
- assertNotNull(executableTable.rowConverter());
+
+ verify(callback).onTableLoaded(eq(executableTable), eq(TABLE_NAME),
eq(descriptor));
Review Comment:
Done. This was removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
