korlov42 commented on code in PR #2671:
URL: https://github.com/apache/ignite-3/pull/2671#discussion_r1360219873
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImpl.java:
##########
@@ -746,6 +735,25 @@ public T get() {
}
}
+ private static Map.Entry<List<RexNode>, RelDataType>
shrinkBounds(IgniteTypeFactory factory, List<RexNode> bound, RelDataType
rowType) {
Review Comment:
TBH, I don't fully understand this `shrinkBounds` thing... Let's add tests
for `ExpressionFactoryImpl#ranges`. That way it will be easier to verify and
debug. Besides, it would be nice to describe how expand bound is supposed work,
what invariants it relies on, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
