zstan commented on code in PR #2671:
URL: https://github.com/apache/ignite-3/pull/2671#discussion_r1363635694
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImplTest.java:
##########
@@ -176,6 +189,60 @@ public void testRangeConditionWithNullIsIgnored() {
assertEquals(List.of(new TestRange(new Object[]{1})), list);
}
+ @ParameterizedTest(name = "condition satisfies: [{0}] the index")
+ @ValueSource(booleans = {true, false})
Review Comment:
you are right i just think that this case is need to be covered too,
additionally such a test is more easy to use for debug than integration one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
