xtern commented on code in PR #2671:
URL: https://github.com/apache/ignite-3/pull/2671#discussion_r1363587785
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImplTest.java:
##########
@@ -176,6 +189,60 @@ public void testRangeConditionWithNullIsIgnored() {
assertEquals(List.of(new TestRange(new Object[]{1})), list);
}
+ @ParameterizedTest(name = "condition satisfies: [{0}] the index")
+ @ValueSource(booleans = {true, false})
Review Comment:
I am not fully understand the idea behind `conditionSatisfyIdx = false` test
case.
Seems the handling of this case was not changed by this patch. But maybe you
know better why this test case is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
