sashapolo commented on code in PR #2722:
URL: https://github.com/apache/ignite-3/pull/2722#discussion_r1365870464
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/TombstoneCondition.java:
##########
@@ -23,18 +23,51 @@
* Condition tests an entry's value is tombstone in meta storage. Entry is
tombstone if it is not empty and doesn't exists.
*/
public class TombstoneCondition extends AbstractSimpleCondition {
+ /** Condition type. */
+ private final TombstoneCondition.Type type;
Review Comment:
Why do we need this enum, can we have a separate class, like
`NotTombstoneCondition`? If this is needed to make it similar to
`ExistenceCondition`, then I would propose to make a separate class for it as
well
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/dsl/Conditions.java:
##########
@@ -256,6 +256,19 @@ public static SimpleCondition tombstone(ByteArray key) {
.build();
}
+ /**
+ * Produces the condition of type {@link ConditionType#NOT_TOMBSTONE}.
This condition tests that an entry's value, identified by the
+ * given key, is not tombstone.
Review Comment:
```suggestion
* given key, is not a tombstone.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
