sashapolo commented on code in PR #2722:
URL: https://github.com/apache/ignite-3/pull/2722#discussion_r1366533893
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/TombstoneCondition.java:
##########
@@ -23,18 +23,51 @@
* Condition tests an entry's value is tombstone in meta storage. Entry is
tombstone if it is not empty and doesn't exists.
*/
public class TombstoneCondition extends AbstractSimpleCondition {
+ /** Condition type. */
+ private final TombstoneCondition.Type type;
Review Comment:
Regarding `RevisionCondition` and `ValueCondition`, having a separate enum
there is somewhat justified, because its has so many implementations which
share the same set of fields. In case of `TombstoneCondition` it looks like an
overcomplication, becuase it only has two types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
