alievmirza commented on code in PR #2722:
URL: https://github.com/apache/ignite-3/pull/2722#discussion_r1366150205
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/TombstoneCondition.java:
##########
@@ -23,18 +23,51 @@
* Condition tests an entry's value is tombstone in meta storage. Entry is
tombstone if it is not empty and doesn't exists.
*/
public class TombstoneCondition extends AbstractSimpleCondition {
+ /** Condition type. */
+ private final TombstoneCondition.Type type;
Review Comment:
Yes, this was done to follow the general pattern that is implemented in
`ExistenceCondition`, `RevisionCondition` or `ValueCondition`. For your
proposed change it would be reasonable to separate all types from
`org.apache.ignite.internal.metastorage.server.RevisionCondition.Type` and
`ValueCondition` as well, but I don't see the justification for such a big
refactoring, so I would stick with the proposed solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
