vldpyatkov commented on code in PR #2757:
URL: https://github.com/apache/ignite-3/pull/2757#discussion_r1373082685
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -787,6 +790,13 @@ public CompletableFuture<Void> closeAsync() {
}
private void enlistPartitions(MappedFragment mappedFragment,
InternalTransaction tx) {
+ // It's possible to have null txState if transaction isn't started
yet.
+ if (tx != null && !(tx.state() == TxState.PENDING || tx.state() ==
null)) {
Review Comment:
It will propagate deeper and will be considered a new one (different from
this transaction). But I know what you mean: "the new transaction will have the
same ID".
Unfortunately, we did not resolve the issue before because we thought it had
been resolved on the server side. But it does not work as expected.
Maybe we should review our decision....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
