ygerzhedovich commented on code in PR #2757:
URL: https://github.com/apache/ignite-3/pull/2757#discussion_r1373084387
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -787,6 +790,13 @@ public CompletableFuture<Void> closeAsync() {
}
private void enlistPartitions(MappedFragment mappedFragment,
InternalTransaction tx) {
+ // It's possible to have null txState if transaction isn't started
yet.
Review Comment:
Interface InternalTransaction doesn't say that can be null. If you
defenetely sure that possible seems it should be reflected for interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
