Cyrill commented on code in PR #4135:
URL: https://github.com/apache/ignite-3/pull/4135#discussion_r1706568086
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -897,7 +897,7 @@ private void
verifyThatRaftNodesAndReplicasWereStartedOnlyOnce() throws Exceptio
verify(getNode(i).raftManager,
timeout(AWAIT_TIMEOUT_MILLIS).times(1))
.startRaftGroupNode(any(), any(), any(), any(), any(),
notNull(TopologyAwareRaftGroupServiceFactory.class));
verify(getNode(i).replicaManager,
timeout(AWAIT_TIMEOUT_MILLIS).times(1))
- .startReplica(any(),
any(PendingComparableValuesTracker.class), any());
+ .startReplica(any(), any(), anyBoolean(), any(), any(),
any(), any(), any());
Review Comment:
Could you please limit the types of any? At least to reliably tell one
overload from another. There are too many overloads and it's easy to get a
wrong stubbing when a new parameter is added to the prod code, but is not added
to the test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
