JAkutenshi opened a new pull request, #4194: URL: https://github.com/apache/ignite-3/pull/4194
JIRA Ticket: [IGNITE-22774 | Remove raftClient map from ItTxTestCluster](https://issues.apache.org/jira/browse/IGNITE-22774) ## The goal The goal is to remove `raftClient` from `ItTxTestCluster`. ## The reason All raft-clients are created inside replicas through `ReplicaManager#startReplica`, and most of usages of `raftClient` are effectively useless ## The solution 1. The map `raftClients` is removed. 2. `getLeader` and related assertions are removed. 3. `getLeaderId` method is rewritten as following: ```java int partId = 0; return replicaManagers.get(extractConsistentId(cluster.get(partId))) .replica(new TablePartitionId(tables.get(tableName).tableId(), partId)) .thenApply(replica -> replica.raftClient().leader()) .join(); ``` 4. Replicas are stopped instead of raft-clients from the map as following: ```java for (String consistentId : clusterServices.keySet()) { ReplicaManager replicaManager = replicaManagers.get(consistentId); if (replicaManager == null) { continue; } grpIds.forEach(id -> { try { replicaManager.stopReplica(id); } catch (NodeStoppingException e) { // no-op } }); } ``` 5. Extra map for tables is introduced because we need to get `tableId` in `getLeaderId`. --- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following: \- There is a single JIRA ticket related to the pull request. \- The web-link to the pull request is attached to the JIRA ticket. \- The JIRA ticket has the Patch Available state. \- The description of the JIRA ticket explains WHAT was made, WHY and HOW. \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue. - [ ] **Design:** new code conforms with the design principles of the components it is added to. - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable. - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed. - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources. ### Notes - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
