kgusakov commented on code in PR #4194:
URL: https://github.com/apache/ignite-3/pull/4194#discussion_r1710317050
##########
modules/table/src/testFixtures/java/org/apache/ignite/distributed/ItTxTestCluster.java:
##########
@@ -940,11 +906,25 @@ public void shutdownCluster() {
assertThat(clientTxManager.stopAsync(new ComponentContext()),
willCompleteSuccessfully());
}
- // TODO: should be removed in
https://issues.apache.org/jira/browse/IGNITE-22774
- for (Map.Entry<String, List<RaftGroupService>> e :
raftClients.entrySet()) {
- for (RaftGroupService svc : e.getValue()) {
- svc.shutdown();
+ Set<TablePartitionId> grpIds = tables.values()
+ .stream()
+ .map(table -> new TablePartitionId(table.tableId(), 0))
+ .collect(toSet());
+
+ for (String consistentId : clusterServices.keySet()) {
+ ReplicaManager replicaManager = replicaManagers.get(consistentId);
+
+ if (replicaManager == null) {
+ continue;
}
+
+ grpIds.forEach(id -> {
+ try {
+ replicaManager.stopReplica(id);
+ } catch (NodeStoppingException e) {
Review Comment:
Why do we need this no-op catch? I would prefer to see this exception and
not sweep it under the carpet
##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItTxDistributedTestThreeNodesThreeReplicasCollocated.java:
##########
@@ -50,11 +49,6 @@ public
ItTxDistributedTestThreeNodesThreeReplicasCollocated(TestInfo testInfo) {
@BeforeEach
@Override public void before() throws Exception {
super.before();
-
- assertSame(
Review Comment:
Again, could you explain?
##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItTxDistributedTestSingleNodeCollocated.java:
##########
@@ -46,15 +44,6 @@ protected boolean startClient() {
@Override
public void before() throws Exception {
super.before();
-
Review Comment:
Could you explain why these assertions were useful and why we shouldn't have
the analog now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
