sashapolo commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984614310
##########
modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java:
##########
@@ -186,21 +173,13 @@ public InitParametersBuilder clusterName(String
clusterName) {
* @param clusterConfiguration Cluster configuration.
* @return {@code this} for chaining.
*/
- public InitParametersBuilder clusterConfiguration(String
clusterConfiguration) {
+ public InitParametersBuilder clusterConfiguration(@Nullable String
clusterConfiguration) {
Review Comment:
We need `@Nullable` annotation for the static analysis. I don't think it's a
good idea to change the production code only because of tests. Now I read this
code and have to think why this configuration can be `null` and what does it
mean. If `null` is only used in tests, I would propose to either simply ignore
the IDEA's warning or fix the tests to use some sensible values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
