slukyano commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984978663
##########
modules/runner/src/main/java/org/apache/ignite/InitParameters.java:
##########
@@ -45,17 +46,15 @@ public class InitParameters {
* @param clusterConfiguration Cluster configuration.
*/
InitParameters(
- Collection<String> metaStorageNodeNames,
- Collection<String> cmgNodeNames,
+ @Nullable Collection<String> metaStorageNodeNames,
Review Comment:
I actually refreshed my Effective Java and it does recommend not to use
nullable collections ever. I think it's worth adding to code style then so that
the uses are explicitly allow-listed and justified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
