sashapolo commented on code in PR #5424:
URL: https://github.com/apache/ignite-3/pull/5424#discussion_r2020637502
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -1109,8 +1110,11 @@ private void
sendSafeTimeSyncIfReplicaReady(CompletableFuture<Replica> replicaFu
.build();
replica.processRequest(req, localNodeId).whenComplete((res, ex) -> {
- if (ex != null && !hasCauseOrSuppressed(ex,
NodeStoppingException.class)
- && !hasCauseOrSuppressed(ex, CancellationException.class))
{
+ if (ex != null
+ && !hasCauseOrSuppressed(ex, NodeStoppingException.class)
+ && !hasCauseOrSuppressed(ex, CancellationException.class)
+ && !hasCauseOrSuppressed(ex,
RejectedExecutionException.class)
Review Comment:
This change is not related to this PR in particular, this exception
sometimes gets thrown on node stop, because some tasks get submitted to a
stopped executor. I've seen the same code in some other component, so I copied
the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
