sanpwc commented on code in PR #5424:
URL: https://github.com/apache/ignite-3/pull/5424#discussion_r2020628245
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -1109,8 +1110,11 @@ private void
sendSafeTimeSyncIfReplicaReady(CompletableFuture<Replica> replicaFu
.build();
replica.processRequest(req, localNodeId).whenComplete((res, ex) -> {
- if (ex != null && !hasCauseOrSuppressed(ex,
NodeStoppingException.class)
- && !hasCauseOrSuppressed(ex, CancellationException.class))
{
+ if (ex != null
+ && !hasCauseOrSuppressed(ex, NodeStoppingException.class)
+ && !hasCauseOrSuppressed(ex, CancellationException.class)
+ && !hasCauseOrSuppressed(ex,
RejectedExecutionException.class)
Review Comment:
In what case will RejectedExecutionException be thrown?
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java:
##########
@@ -402,6 +403,50 @@ public void addTableProcessor(int tableId,
RaftTableProcessor processor) {
}
}
+ /**
+ * Adds a given Table Partition-level Raft processor to the set of managed
processors during node recovery on startup.
+ */
+ public void addTableProcessorOnRecovery(int tableId, RaftTableProcessor
processor) {
+ synchronized (tableProcessorsStateLock) {
+ PartitionSnapshotInfo snapshotInfo = snapshotInfo();
+
+ // This method is called on node recovery on order to add existing
table processors to a zone being started. During recovery
Review Comment:
on order to -> **in** order to ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
