rpuch commented on code in PR #6229:
URL: https://github.com/apache/ignite-3/pull/6229#discussion_r2197626520
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorageEngine.java:
##########
@@ -270,4 +273,24 @@ public void destroyMvTable(int tableId) {
rocksDbStorage.rocksDbInstance.destroyTable(tableId);
}
}
+
+ @Override
+ public Set<Integer> tableIdsOnDisk() {
+ return storageByProfileName.values().stream()
+ .flatMap(storage ->
storage.rocksDbInstance.tableIdsInRocksDb().stream())
Review Comment:
With `onDisk` there is a slight semantic problem: it is possible that what
this method returns is not on disk yet; it's *potentially* on disk. `InRocksDb`
describes the situation more precisely, that's why I chose this name.
I can rename it to use `onDisk` as well, it doesn't seem to be a big deal.
Or we could invent a better name for `tableIdsOnDisk`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
