sk0x50 commented on code in PR #6549: URL: https://github.com/apache/ignite-3/pull/6549#discussion_r2321504838
########## modules/api/src/main/java/org/apache/ignite/lang/InvalidUserInputException.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.lang; + +import static org.apache.ignite.lang.ErrorGroups.Common.ILLEGAL_ARGUMENT_ERR; + +import java.util.UUID; +import org.jetbrains.annotations.Nullable; + +/** + * Exception representing user input error. This is used to differentiate from system errors. + */ +public class InvalidUserInputException extends IgniteException { Review Comment: If I am not mistaken, this exception is used as a root cause of the `JoinDeniedException` (which is an internal exception), right? Does it make sense to move this new exception to the api module in this case? I mean that `start` method declared as follows: ``` /** * Starts the node. * * <p>When this method returns, the node is partially started and ready to accept the init command (that is, its * REST endpoint is functional). * * <p>Start can only be called once. */ void start(); ``` It does not declare any specific exceptions. So, I would expect here `RuntimeException` and/or `IgniteException` (which is the base class for all ignite runtime exceptions). Moreover, the following code does not work (perhaps, I am wrong, of course): ``` try { igniteServer.start(); } catch (InvalidUserInputException iuie) { // We'll never get here, right? } ``` I am not against the change you propose, I'm just trying to figure out the details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
