ivanzlenko commented on code in PR #6549: URL: https://github.com/apache/ignite-3/pull/6549#discussion_r2321892294
########## modules/api/src/main/java/org/apache/ignite/lang/InvalidUserInputException.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.lang; + +import static org.apache.ignite.lang.ErrorGroups.Common.ILLEGAL_ARGUMENT_ERR; + +import java.util.UUID; +import org.jetbrains.annotations.Nullable; + +/** + * Exception representing user input error. This is used to differentiate from system errors. + */ +public class InvalidUserInputException extends IgniteException { + public InvalidUserInputException(String message) { + super(ILLEGAL_ARGUMENT_ERR, message); + } + + @SuppressWarnings("unused") Review Comment: The only analysis tool we are rely on is built-in checks in gradle. These checks contains all necessary rules for us. As soon as someone will use this constructor the suppression will became invalid but I bet no one will remove the suppression itself. In general we do not use unused suppressions for mandatory public API methods. Also you will not need this constructor if the exception will be moved outside of the API module. ########## modules/api/src/main/java/org/apache/ignite/lang/InvalidUserInputException.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.lang; + +import static org.apache.ignite.lang.ErrorGroups.Common.ILLEGAL_ARGUMENT_ERR; + +import java.util.UUID; +import org.jetbrains.annotations.Nullable; + +/** + * Exception representing user input error. This is used to differentiate from system errors. + */ +public class InvalidUserInputException extends IgniteException { Review Comment: What do you mean by "bad user input"? The only "bad user input" I could think of which can potentially can lead to the node shutdown is incorrect configuration and startup parameters. Which are pretty specific and can't be categorized as "bad user input". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
