adityamukho commented on code in PR #6549:
URL: https://github.com/apache/ignite-3/pull/6549#discussion_r2348003170
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -1693,20 +1695,26 @@ private RuntimeException handleStartException(Throwable
e) {
var igniteException = new IgniteException(extractCodeFrom(e), errMsg,
e);
- // We log the exception as soon as possible to minimize the
probability that it gets lost due to something like an OOM later.
- LOG.error(errMsg, igniteException);
+ Throwable rootEx = unwrapRootCause(e);
+ if (rootEx instanceof InvalidNodeConfigurationException) {
Review Comment:
If the node needs to be stopped and restarted anyway to fix the
configuration, then probably yes, it should be stopped as part of this error
handling process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
